Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Uptime] increase timeout and clear mocks for UptimeDatePicker flaky test #117346

Conversation

dominiqueclarke
Copy link
Contributor

Summary

Fixes #114396

Increase timeout of flaky UptimeDatePicker test.

This change also clears mocks for this tests, and adjusts the expected values based on the now cleared mocks.

This test has been checked for flakyness by running in a loop for 200 iterations locally.

@dominiqueclarke dominiqueclarke added failed-test A test failure on a tracked branch, potentially flaky-test v8.0.0 Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v7.16.0 labels Nov 3, 2021
@dominiqueclarke dominiqueclarke requested a review from a team as a code owner November 3, 2021 15:24
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@dominiqueclarke dominiqueclarke changed the title increase timeout and clear mocks for UptimeDatePicker flaky test [Uptime] increase timeout and clear mocks for UptimeDatePicker flaky test Nov 3, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@justinkambic justinkambic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

// FLAKY: https://github.com/elastic/kibana/issues/114396
describe.skip('UptimeDatePicker component', () => {
describe('UptimeDatePicker component', () => {
jest.setTimeout(10_000);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
jest.setTimeout(10_000);
jest.setTimeout(10_000);

Always love seeing that syntax 🥇

@dominiqueclarke dominiqueclarke merged commit edd53f3 into elastic:main Nov 3, 2021
@dominiqueclarke dominiqueclarke deleted the fix/uptime-date-picker-flaky-test branch November 3, 2021 19:23
@kibanamachine
Copy link
Contributor

The following labels were identified as gaps in your version labels and will be added automatically:

  • v8.1.0

If any of these should not be on your pull request, please manually remove them.

@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
8.0
7.16

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Nov 3, 2021
…test (#117346) (#117416)

Co-authored-by: Dominique Clarke <doclarke71@gmail.com>
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 4, 2021
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

1 similar comment
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

kibanamachine added a commit that referenced this pull request Nov 9, 2021
…test (#117346) (#117417)

Co-authored-by: Dominique Clarke <doclarke71@gmail.com>
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed failed-test A test failure on a tracked branch, potentially flaky-test release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.16.0 v8.0.0 v8.1.0
Projects
None yet
4 participants