-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Uptime] increase timeout and clear mocks for UptimeDatePicker flaky test #117346
[Uptime] increase timeout and clear mocks for UptimeDatePicker flaky test #117346
Conversation
Pinging @elastic/uptime (Team:uptime) |
💚 Build Succeeded
Metrics [docs]
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
// FLAKY: https://github.com/elastic/kibana/issues/114396 | ||
describe.skip('UptimeDatePicker component', () => { | ||
describe('UptimeDatePicker component', () => { | ||
jest.setTimeout(10_000); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jest.setTimeout(10_000); | |
jest.setTimeout(10_000); |
Always love seeing that syntax 🥇
The following labels were identified as gaps in your version labels and will be added automatically:
If any of these should not be on your pull request, please manually remove them. |
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
1 similar comment
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
Summary
Fixes #114396
Increase timeout of flaky UptimeDatePicker test.
This change also clears mocks for this tests, and adjusts the expected values based on the now cleared mocks.
This test has been checked for flakyness by running in a loop for 200 iterations locally.